-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference reactor-ts as module #1322
Conversation
Such issues as these may delay progress for some days. |
28ab79c
to
e8d43c4
Compare
This change is made out of pure laziness. Human time is worth more than computer time -- and disk space.
f0e774f
to
15177bd
Compare
15177bd
to
e165600
Compare
I just ran into an issue where the generated directory for Minimal.lf consumes over 300 MB 😅 which is why we ran out of disk space on Windows in CI. Even in |
6f966e7
to
58a7ed0
Compare
58a7ed0
to
ce663f1
Compare
8a86cca
to
1e848bc
Compare
1e848bc
to
6a60cb3
Compare
Okay, I followed through with what I talked about with Marten (not bothering to pre-bundle the runtime or to install its dependencies) and the tests seem to be passing now, except for the LSP tests. I will try to get this done this weekend, although I might be sidetracked/delayed by the fact that the |
There is no need to use resolve because we are copying from class path, where paths are standardized to use / as a separator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments...
Here is the result of running
The dev dependencies are not even installed by our code generator, I believe, so they should not matter for compile times. I do not require any dependency removals to be low-hanging fruit. Any protobuf-related dependency removal will require us to edit the Is there any reason not to merge this as-is? |
This PR changes the build process to, rather than compile generated code in conjunction with the
reactor-ts
code, compile separately and importreactor-ts
as a module. In principle, this flow would enable buildingreactor-ts
just once and reuse it for all tests, but we currently don't do this (yet). Oncereactor-ts
stabilizes and has regular releases, it should suffice to treat is as a normal dependency and pull it from NPM like all other dependencies. Then,pnpm
can take care of caching, which should speed up build times considerably.